bodnuti: [OE-core][PATCH v6 0/7] Implement SPDX for deploy tasks base: fa83da7da277 [OE-core][PATCH v6 5/7] classes-recipe/deploy: Add do_deploy to SPDX_DEPLOY_TASKS WARNING oelint oelint.vars.mispell.unknown meta/classes-recipe/deploy.bbclass:9 'SPDX_DEPLOY_TASKS' is unknown. Consider adding it via --constantmods 6 | 7 | DEPLOYDIR = "${WORKDIR}/deploy-${PN}" 8 | SSTATETASKS += "do_deploy" > 9 | SPDX_DEPLOY_TASKS += "do_deploy" 10 | SPDX_DEPLOY_ARTIFACTS_DIR:task-deploy = "${DEPLOYDIR}" 11 | do_deploy[sstate-inputdirs] = "${DEPLOYDIR}" 12 | do_deploy[sstate-outputdirs] = "${DEPLOY_DIR_IMAGE}" WARNING oelint oelint.vars.mispell.unknown meta/classes-recipe/deploy.bbclass:10 'SPDX_DEPLOY_ARTIFACTS_DIR' is unknown. Consider adding it via --constantmods 7 | DEPLOYDIR = "${WORKDIR}/deploy-${PN}" 8 | SSTATETASKS += "do_deploy" 9 | SPDX_DEPLOY_TASKS += "do_deploy" > 10 | SPDX_DEPLOY_ARTIFACTS_DIR:task-deploy = "${DEPLOYDIR}" 11 | do_deploy[sstate-inputdirs] = "${DEPLOYDIR}" 12 | do_deploy[sstate-outputdirs] = "${DEPLOY_DIR_IMAGE}" 13 | [OE-core][PATCH v6 6/7] spdx: Replace do_create_image_spdx with deploy task WARNING oelint oelint.vars.mispell.unknown meta/classes-recipe/create-spdx-image-3.0.bbclass:55 'oe.spdx30_tasks.create_image_spdx' is unknown. Consider adding it via --constantmods 52 | 53 | oe.spdx30_tasks.create_image_spdx(d, spdxdeploydir) 54 | } > 55 | oe.spdx30_tasks.create_image_spdx[vardeps] += "SPDX_IMAGE_PURPOSE" 56 | SPDX_DEPLOY_TASKS += "do_image_complete:create_image_spdx" 57 | # No deploy sbom is needed since do_create_image_sbom_spdx() is used instead 58 | SPDX_DEPLOY_SBOM = "0" WARNING oelint oelint.vars.mispell.unknown meta/classes-recipe/create-spdx-image-3.0.bbclass:56 'SPDX_DEPLOY_TASKS' is unknown. Consider adding it via --constantmods 53 | oe.spdx30_tasks.create_image_spdx(d, spdxdeploydir) 54 | } 55 | oe.spdx30_tasks.create_image_spdx[vardeps] += "SPDX_IMAGE_PURPOSE" > 56 | SPDX_DEPLOY_TASKS += "do_image_complete:create_image_spdx" 57 | # No deploy sbom is needed since do_create_image_sbom_spdx() is used instead 58 | SPDX_DEPLOY_SBOM = "0" 59 | WARNING oelint oelint.vars.mispell.unknown meta/classes-recipe/create-spdx-image-3.0.bbclass:58 'SPDX_DEPLOY_SBOM' is unknown. Consider adding it via --constantmods 55 | oe.spdx30_tasks.create_image_spdx[vardeps] += "SPDX_IMAGE_PURPOSE" 56 | SPDX_DEPLOY_TASKS += "do_image_complete:create_image_spdx" 57 | # No deploy sbom is needed since do_create_image_sbom_spdx() is used instead > 58 | SPDX_DEPLOY_SBOM = "0" 59 | 60 | python do_create_image_sbom_spdx() { 61 | import oe.spdx30_tasks WARNING oelint oelint.vars.mispell meta/classes/create-spdx-3.0.bbclass:192 'SPDX_DEPLOY_SBOM_NAME' is unknown, maybe you meant 'SPDX_RECIPE_SBOM_NAME' 189 | If the recipe already has another task to create an SBoM, this should be \ 190 | set to '0' to prevent multiple SBoMs from being created." 191 | > 192 | SPDX_DEPLOY_SBOM_NAME ?= "${PN}-deploy-sbom" 193 | SPDX_DEPLOY_SBOM_NAME[doc] = "The name of the output deploy SBoM when using \ 194 | create_deploy_sbom" 195 | WARNING oelint oelint.vars.mispell meta/classes/create-spdx-3.0.bbclass:193 'SPDX_DEPLOY_SBOM_NAME' is unknown, maybe you meant 'SPDX_RECIPE_SBOM_NAME' 190 | set to '0' to prevent multiple SBoMs from being created." 191 | 192 | SPDX_DEPLOY_SBOM_NAME ?= "${PN}-deploy-sbom" > 193 | SPDX_DEPLOY_SBOM_NAME[doc] = "The name of the output deploy SBoM when using \ 194 | create_deploy_sbom" 195 | 196 | SPDX_DEPLOY_ARTIFACTS = "AUTO" WARNING oelint oelint.vars.mispell.unknown meta/classes/create-spdx-3.0.bbclass:197 'SPDX_DEPLOY_ARITFACTS' is unknown. Consider adding it via --constantmods 194 | create_deploy_sbom" 195 | 196 | SPDX_DEPLOY_ARTIFACTS = "AUTO" > 197 | SPDX_DEPLOY_ARITFACTS[doc] = "A space separated list of deployed artifacts, \ 198 | relative to SPDX_DEPLOY_ARTIFACTS_DIR that should be included in the SBoM. \ 199 | If 'AUTO' (the default), all files in SPDX_DEPLOY_ARITFACTS_DIR will be \ 200 | added. A :task- override *must* be used to set this value so that it is \ WARNING oelint oelint.vars.mispell.unknown meta/classes/create-spdx-3.0.bbclass:355 'oe.spdx30_tasks.find_build_dep_objsets' is unknown. Consider adding it via --constantmods 352 | 353 | oe.spdx30_tasks.create_deploy_spdx(d, spdxdeploydir, artifactsdir, artifacts) 354 | } > 355 | oe.spdx30_tasks.find_build_dep_objsets[vardepsexclude] += "BB_TASKDEPDATA" 356 | 357 | python () { 358 | # Most recipes generate SPDX output in a distinct task from the task that WARNING oelint oelint.task.noanonpython meta/classes/create-spdx-3.0.bbclass:357 Avoid anonymous python functions as they are expensive and come with all sorts of side effects 354 | } 355 | oe.spdx30_tasks.find_build_dep_objsets[vardepsexclude] += "BB_TASKDEPDATA" 356 | > 357 | python () { 358 | # Most recipes generate SPDX output in a distinct task from the task that 359 | # actually is the relevant dependency. As such, we need to map the task 360 | # that we care about to the task that generates the corresponding SPDX WARNING oelint oelint.vars.mispell.unknown meta/classes/create-spdx-3.0.bbclass:473 'SSTATE_SKIP_CREATION' is unknown. Consider adding it via --constantmods 470 | sstate_setscene(d) 471 | } 472 | addtask do_create_deploy_sbom_setscene > 473 | SSTATE_SKIP_CREATION:task-create-deploy-sbom = "1" WARNING oelint oelint.vars.mispell meta/classes/spdx-common.bbclass:28 'SPDXDEPLOYSBOMDEPLOY' is unknown, maybe you meant 'SPDXRECIPESBOMDEPLOY' 25 | SPDXRECIPEDEPLOY = "${SPDXDIR}/recipe-deploy" 26 | SPDXRUNTIMEDEPLOY = "${SPDXDIR}/runtime-deploy" 27 | SPDXRECIPESBOMDEPLOY = "${SPDXDIR}/recipes-bom-deploy" > 28 | SPDXDEPLOYSBOMDEPLOY = "${SPDXDIR}/deploy-bom-deploy" 29 | 30 | SPDX_INCLUDE_SOURCES ??= "0" 31 | SPDX_INCLUDE_SOURCES[doc] = "If set to '1', include source code files in the \ style INFO oelint oelint.task.docstrings meta/classes-recipe/create-spdx-image-3.0.bbclass:46 Every custom task should have a doc string set by task[doc] = '...' 43 | } 44 | addtask do_create_rootfs_spdx_setscene 45 | > 46 | python create_image_spdx() { 47 | import oe.spdx30_tasks 48 | from pathlib import Path 49 | current_task = "do_" + d.getVar("BB_CURRENTTASK") INFO oelint oelint.task.docstrings meta/classes/create-spdx-3.0.bbclass:339 Every custom task should have a doc string set by task[doc] = '...' 336 | addhandler spdx30_build_started_handler 337 | spdx30_build_started_handler[eventmask] = "bb.event.BuildStarted" 338 | > 339 | python create_deploy_spdx() { 340 | import oe.spdx30_tasks 341 | from pathlib import Path 342 | current_task = "do_" + d.getVar("BB_CURRENTTASK") INFO oelint oelint.task.docstrings meta/classes/create-spdx-3.0.bbclass:450 Every custom task should have a doc string set by task[doc] = '...' 447 | bb.build.addtask("do_create_deploy_sbom", "do_build", " ".join(deploy_sbom_tasks), d) 448 | } 449 | > 450 | python do_create_deploy_sbom() { 451 | import oe.spdx30_tasks 452 | from pathlib import Path 453 | deploydir = Path(d.getVar("SPDXDEPLOYSBOMDEPLOY")) INFO oelint oelint.task.docstrings meta/classes/create-spdx-3.0.bbclass:469 Every custom task should have a doc string set by task[doc] = '...' 466 | do_create_deploy_sbom[file-checksums] += "${SPDX3_DEP_FILES}" 467 | 468 | SSTATETASKS += "do_create_deploy_sbom" > 469 | python do_create_deploy_sbom_setscene() { 470 | sstate_setscene(d) 471 | } 472 | addtask do_create_deploy_sbom_setscene patchtest: 70 pass, 0 fail, 35 skip 12 findings: 0 errors, 12 warnings, 0 info (4 style, not counted)