bodnuti: [PATCH v5 0/6] uboot-sign: sign the SPL FIT configuration
base: ae5cafacec8e

[PATCH v5 5/6] uboot-sign: enable signing SPL FIT configuration

  WARNING oelint oelint.task.heredocs  meta/classes-recipe/uboot-sign.bbclass:475
      Usage of heredocs should be avoided. Use files instead
      472 | EOF
      473 | 
      474 | 	if [ "${SPL_SIGN_ENABLE}" = "1" ] && [ "${SPL_SIGN_CONF}" = "1" ] ; then
    > 475 | 		cat << EOF >> ${UBOOT_ITS}
      476 |             hash-1 {
      477 |                 algo = "${UBOOT_FIT_HASH_ALG}";
      478 |             };

  WARNING oelint oelint.task.heredocs  meta/classes-recipe/uboot-sign.bbclass:483
      Usage of heredocs should be avoided. Use files instead
      480 | 	fi
      481 | 
      482 | 	if [ "${SPL_SIGN_ENABLE}" = "1" ] && [ "${SPL_SIGN_INDIVIDUAL}" = "1" ] ; then
    > 483 | 		cat << EOF >> ${UBOOT_ITS}
      484 |             signature {
      485 |                 algo = "${UBOOT_FIT_HASH_ALG},${UBOOT_FIT_SIGN_ALG}";
      486 |                 key-name-hint = "${SPL_SIGN_KEYNAME}";

  WARNING oelint oelint.task.heredocs  meta/classes-recipe/uboot-sign.bbclass:491
      Usage of heredocs should be avoided. Use files instead
      488 | EOF
      489 | 	fi
      490 | 
    > 491 | 	cat << EOF >> ${UBOOT_ITS}
      492 |         };
      493 | EOF
      494 | 	if [ "${UBOOT_FIT_TEE}" = "1" ] ; then

  WARNING oelint oelint.task.heredocs  meta/classes-recipe/uboot-sign.bbclass:530
      Usage of heredocs should be avoided. Use files instead
      527 | 	fi
      528 | 	conf_sign_images="${conf_sign_images}${conf_sign_images_sep}\"fdt\""
      529 | 
    > 530 | 	cat << EOF >> ${UBOOT_ITS}
      531 |     };
      532 | 
      533 |     configurations {

  WARNING oelint oelint.task.heredocs  meta/classes-recipe/uboot-sign.bbclass:543
      Usage of heredocs should be avoided. Use files instead
      540 | EOF
      541 | 
      542 | 	if [ "${SPL_SIGN_ENABLE}" = "1" ] && [ "${SPL_SIGN_CONF}" = "1" ] ; then
    > 543 | 		cat << EOF >> ${UBOOT_ITS}
      544 |             signature {
      545 |                 algo = "${UBOOT_FIT_HASH_ALG},${UBOOT_FIT_SIGN_ALG}";
      546 |                 key-name-hint = "${SPL_SIGN_KEYNAME}";

  WARNING oelint oelint.task.heredocs  meta/classes-recipe/uboot-sign.bbclass:552
      Usage of heredocs should be avoided. Use files instead
      549 | EOF
      550 | 	fi
      551 | 
    > 552 | 	cat << EOF >> ${UBOOT_ITS}
      553 |         };
      554 |     };
      555 | };

  WARNING shellcheck SC2164  meta/classes-recipe/uboot-sign.bbclass:645
      Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
      642 | 
      643 | 			config_binary=$(uboot_config_get_indexed_value "${UBOOT_CONFIG_BINARY}" $i)
      644 | 
    > 645 | 			cd ${B}/${builddir}
      646 | 			uboot_assemble_fitimage_helper ${type} ${config_binary}
      647 | 		done
      648 | 	else

  WARNING shellcheck SC2164  meta/classes-recipe/uboot-sign.bbclass:649
      Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
      646 | 			uboot_assemble_fitimage_helper ${type} ${config_binary}
      647 | 		done
      648 | 	else
    > 649 | 		cd ${B}
      650 | 		uboot_assemble_fitimage_helper "" ${UBOOT_BINARY}
      651 | 	fi
      652 | }

  WARNING shellcheck SC2164  meta/classes-recipe/uboot-sign.bbclass:695
      Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
      692 | 				j=$(expr $j + 1);
      693 | 				if [ $j -eq $i ]; then
      694 | 					builddir="${config}-${type}"
    > 695 | 					cd ${B}/${builddir}
      696 | 					deploy_helper ${type}
      697 | 				fi
      698 | 			done

  WARNING shellcheck SC2164  meta/classes-recipe/uboot-sign.bbclass:703
      Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
      700 | 		done
      701 | 		unset i
      702 | 	else
    > 703 | 		cd ${B}
      704 | 		deploy_helper ""
      705 | 	fi
      706 | 

patchtest: 60 pass, 0 fail, 30 skip
10 findings: 0 errors, 10 warnings, 0 info